Cocos2d-x 3.17 Android crashes with NullPointerException in org.cocos2dx.lib.Cocos2dxHelper.runOnGLThread

vkreal2 · September 9, 2018, 5:00pm

Anyone have any clue on this null pointer? Getting bunch of them in Google console using 3.17. Thanks!

java.lang.RuntimeException: 
  at android.app.ActivityThread.performDestroyActivity (ActivityThread.java:4897)
  at android.app.ActivityThread.handleDestroyActivity (ActivityThread.java:4915)
  at android.app.ActivityThread.access$1600 (ActivityThread.java:211)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1759)
  at android.os.Handler.dispatchMessage (Handler.java:102)
  at android.os.Looper.loop (Looper.java:145)
  at android.app.ActivityThread.main (ActivityThread.java:6946)
  at java.lang.reflect.Method.invoke (Native Method)
  at java.lang.reflect.Method.invoke (Method.java:372)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1404)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1199)
Caused by: java.lang.NullPointerException: 
  at org.cocos2dx.lib.Cocos2dxHelper.runOnGLThread (Cocos2dxHelper.java:109)
  at org.cocos2dx.lib.Cocos2dxAudioFocusManager.unregisterAudioFocusListener (Cocos2dxAudioFocusManager.java:122)
  at org.cocos2dx.lib.Cocos2dxActivity.onDestroy (Cocos2dxActivity.java:230)
  at android.app.Activity.performDestroy (Activity.java:6809)
  at android.app.Instrumentation.callActivityOnDestroy (Instrumentation.java:1169)
  at android.app.ActivityThread.performDestroyActivity (ActivityThread.java:4875)

daisuke7 · September 14, 2018, 10:35am

Same problem?
3.16 version helloworld project crash when add SplashActivity #18884

vkreal2 · September 14, 2018, 2:57pm

@daisuke7 looks like it might be same problem. Thank you!

vkreal2 · September 14, 2018, 3:41pm

@slackmoehrle anyway your team can look into this? We are seeing a lot of these crashes in the Play Console.

Look like this fix below is causing NullPointerException .

github.com

cocos2d/cocos2d-x/blob/v3/cocos/platform/android/java/src/org/cocos2dx/lib/Cocos2dxActivity.java#L131




// ===========================================================
// Constructors
// ===========================================================


@Override
protected void onCreate(final Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);


    // Workaround in https://stackoverflow.com/questions/16283079/re-launch-of-activity-on-home-button-but-only-the-first-time/16447508
    if (!isTaskRoot()) {
        // Android launched another instance of the root activity into an existing task
        //  so just quietly finish and go away, dropping the user back into the activity
        //  at the top of the stack (ie: the last state of this task)
        finish();
        Log.w(TAG, "[Workaround] Ignore the activity started from icon!");
        return;
    }


    this.hideVirtualButton();

slackmoehrle · September 15, 2018, 4:57am

@drelaptop do you have any thoughts?

drelaptop · September 15, 2018, 8:39am

I think below is a better solution, please refer to

vkreal2 · September 15, 2018, 4:33pm

@drelaptop to clarify should we keep the hack code block below?

github.com

cocos2d/cocos2d-x/blob/v3/cocos/platform/android/java/src/org/cocos2dx/lib/Cocos2dxActivity.java#L131




// ===========================================================
// Constructors
// ===========================================================


@Override
protected void onCreate(final Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);


    // Workaround in https://stackoverflow.com/questions/16283079/re-launch-of-activity-on-home-button-but-only-the-first-time/16447508
    if (!isTaskRoot()) {
        // Android launched another instance of the root activity into an existing task
        //  so just quietly finish and go away, dropping the user back into the activity
        //  at the top of the stack (ie: the last state of this task)
        finish();
        Log.w(TAG, "[Workaround] Ignore the activity started from icon!");
        return;
    }


    this.hideVirtualButton();

drelaptop · September 16, 2018, 4:38am

yes, for the origin issue the hack code solved didn’t been solved, this comment