Why Cocos2d-x v3.2 purgeDirector doesn't call onExitTransitionDidStart()?

cocos2d-x C++
#1

Hi,

When using cocos2d-x v2.x the method Node::onExitTransitionDidStart was called on the current scene when the director was purged. This made sense, because it allowed me to follow a well defined lifecycle in my nodes. I know that I could do my cleaning behavior on onExitTransitionDidStart.

Starting with this commit

onExitTransitionDidStart is no longer called when the Director is purged.

What was the rationale behind this decision? Doesn’t it make sense for onExitTrantisionDidStart to be called when the director is purged?

(by the way, is there any way to see what comments/discussions reference a given commit in github?)

#2

A commit can be commented. Unfortunately they don’t do it.

You could search for the references, e.g. the SHA or the ones, which can be used:
https://help.github.com/articles/writing-on-github#references

1 Like
#3

Thank you once again @iQD I was able to find the matching PR

Even so, my question remains. The original issue mentions onExitTransitionDidStart being called multiple times but I don’t think that can happen on purgeDirector and it certainly doesn’t happen to me now (onExitTransitionDidStart is never called)

My question remains, what’s the rationale behind removing onExitTransitionDidStart from purgeDirector? It seems a bug as it currently stands