const char* in createWithContentsOfFile


#1

Hi!
__Dictionary::createWithContentsOfFile takes const char* as a parameter while __Array::createWithContentsOfFile takes const string&. I think this should be fixed.


#2

@elvman

Yeah, I agree all the code style should be consistent.

But both __Dictionary and __Array are deprecated in 3.0.

You should use Value and ValueMap instead.

The deprecated methods and classes will be removed in the future version.


#3

Thank you, they aren’t declared deprecated, that is why I used them. I will switch to Value and ValueMap now.